DELETE /admin/routes/{id} can never delete a route that exists

Nobody has started this yet — be first.

Business impact

Operators use DELETE /admin/routes/{id} to pull a route out of service -- decommissioning an old upstream, cutting off a route someone misconfigured, removing access during an incident. Right now that does not work: deleting a route that is actually in the table always 404s, so the only way to remove a route is a full POST /admin/routes/reload from a hand-edited routes.yaml (a much riskier, all-or-nothing operation) or restarting the process. During an incident where the fastest fix is "just take this one route out," that extra friction costs real time.

Problem

RouteTable.delete() raises RouteNotFoundError -- which the admin API turns into a 404 -- for exactly the routes that DO exist, and silently "succeeds" (204, no-op) for route IDs that do not exist.

Current behavior

delete()'s existence check is inverted: the condition guarding the "raise RouteNotFoundError" branch is testing membership in self._by_id the wrong way around, so the raise and no-op branches fire for the opposite cases from what "not found" should mean.

Expected behavior

Deleting a route ID that exists in the table removes it and returns 204. Deleting a route ID that does not exist returns 404.

Steps to reproduce

PUT /admin/routes/foo to create route foo.
DELETE /admin/routes/foo.
Observe: 404 ("no such route: foo"), and a subsequent GET /admin/routes/foo still returns the route -- it was never removed.

Why this matters

This is an inverted boolean condition -- the kind of one-character mistake that a quick manual test with a route ID that does not exist yet ("does deleting a nonexistent route correctly 404?" -- yes! by accident) would never catch, because the bug only shows up on the path most people do not think to double-check: deleting something that is actually there.

Suggested approach

Read the two lines of delete() closely: one condition decides whether to raise RouteNotFoundError, and it is testing for the wrong thing relative to what "not found" should mean.

Acceptance criteria

Deleting an existing route ID succeeds (204) and the route is gone from a subsequent list()/GET
Deleting a nonexistent route ID raises RouteNotFoundError (404 via the admin API)

Verification

pytest practice_tickets/tests/test_ticket_04_delete_route_inverted_check.py -v

Hints (0/2)

Try it without hints first — the reading is the exercise.

Working on this ticket

Work on a branch named for the ticket — that's what you'll submit.

Branch off your fork

$git checkout -b fix/delete-route-inverted-check

Fix it and commit

Meet every acceptance criterion, and add a test that would have caught this.

Push the branch

$git push -u origin fix/delete-route-inverted-check

Submit it below

Paste your fork URL and the branch name, with a short write-up of the root cause.

Submit your fix

Questions

Stuck on something?

Ask about anything unclear in the ticket — the maintainer and anyone who has solved it can answer. Please don't post full solutions.

No questions yet. If something in this ticket reads ambiguously, you are probably not the only one — ask.

The project

Dynamic API Gateway & Reverse Proxy

A FastAPI reverse proxy that streams every request and response without ever buffering a body in full, with hot-reloadable routing, per-route auth, Redis token-bucket rate limiting, and a per-upstream circuit breaker.

Fork on GitHub

Download

Setup

Dynamic API Gateway & Reverse Proxy

git clone <your-fork>
cd FastAPIDevTraining/gateway_proxy
cp .env.example .env   # adjust GATEWAY_ADMIN_TOKEN etc. if you like
docker compose up --build   # Redis + the gateway (uvicorn --reload) + 2 demo upstreams

The gateway is reachable at . Two demo upstreams come up alongside it — (low-latency JSON echo at , plus for the streaming-passthrough demo) and (, , for timeout and circuit-breaker demos) — and wires five example routes against them, one per feature. Verify the stack with (liveness only) and (pings Redis, which every rate-limited route depends on). Every endpoint (route CRUD, reload, persist, breaker snapshot) requires .