"decline" demo profile silently approves instead

This is the demo bank/UPI simulator, so nothing real is at stake -- but imagine it wasn't a demo. simulator_profile: "decline" exists so QA, demos, and integration tests can deterministically prove the created -> failed path works. If it silently approves instead, every test and demo that relies on it to exercise the decline branch is actually testing nothing -- a false green across the board. In a real issuer integration this exact class of bug (a response-code mapping inverted) is how a "payment declined" webhook ends up crediting an order that was never actually paid for.

Simulator.Initiate called with Profile: "decline" returns Outcome: "approved" instead of Outcome: "declined".

go test ./tickets/tests/... -run TestTicket03 -v

Or manually, once the server is running:

curl -s -X POST localhost:8080/v1/payments
-d '{"amount_minor": 1000, "currency": "INR", "simulator_profile": "decline"}'

wait a moment, then:

curl -s localhost:8080/v1/payments/<id>

-> currently ends up "authorized", should end up "failed"

Simulator.Initiate's switch req.Profile has one case per profile, each returning a Result{Outcome: ..., Detail: ...}. The Detail string for the ProfileDecline case correctly says "issuer declined the collect request" -- but the Outcome field right next to it names the wrong constant. internal/outbox.Dispatcher.resolve switches on outcome.Outcome (not Detail) to decide whether to fire authorize or decline against the payment machine, so this is the field that actually drives behavior.

Look at the case payment.ProfileDecline: branch in internal/bank/simulator.go's Initiate, and compare its Outcome value against the two exported constants bank.OutcomeApproved / bank.OutcomeDeclined declared right above it.